Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http client component to runtime extension #899

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

AndrewFossAWS
Copy link
Contributor

@AndrewFossAWS AndrewFossAWS commented Aug 28, 2023

This PR adds http client component to the runtime extensions.

Using S3 as an example:

export class CustomHttpExtension implements RuntimeExtension {
    configure(extensionConfiguration: S3ExtensionConfiguration): void {
       extensionConfiguration.setHttpHandler(...);
       extensionConfiguration.updateHttpClientConfig("requestTimeout", requestTimeout);
    }
}

// extensions can be passed via the client constructor object
S3Client({
  ...
  extensions: [CustomHttpExtension()]
})

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AndrewFossAWS AndrewFossAWS requested review from a team as code owners August 28, 2023 22:08
@AndrewFossAWS AndrewFossAWS force-pushed the http-ext branch 5 times, most recently from c4dbce3 to fa4c822 Compare August 29, 2023 15:06
Copy link
Contributor

@kuhe kuhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any should be replaced by types

@AndrewFossAWS AndrewFossAWS force-pushed the http-ext branch 5 times, most recently from fbf7c58 to f6b5e2a Compare September 1, 2023 00:01
Copy link
Contributor

@syall syall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I also agree with @kuhe's comments.

.changeset/three-nails-press.md Outdated Show resolved Hide resolved
@AndrewFossAWS AndrewFossAWS merged commit a03026e into smithy-lang:main Sep 5, 2023
7 checks passed
kstich added a commit to kstich/smithy-typescript that referenced this pull request Sep 28, 2023
This commit adds the `LazyJsonString` class that supports holding a
String with JSON contents, deserializing to JSON, and being built
from JSON like content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants