-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http client component to runtime extension #899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
force-pushed
the
http-ext
branch
5 times, most recently
from
August 29, 2023 15:06
c4dbce3
to
fa4c822
Compare
kuhe
reviewed
Aug 30, 2023
kuhe
reviewed
Aug 30, 2023
kuhe
reviewed
Aug 30, 2023
kuhe
reviewed
Aug 30, 2023
kuhe
reviewed
Aug 30, 2023
kuhe
requested changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any
should be replaced by types
kuhe
reviewed
Aug 30, 2023
kuhe
reviewed
Aug 30, 2023
kuhe
reviewed
Aug 30, 2023
packages/protocol-http/src/extensions/httpExtensionConfiguration.ts
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
http-ext
branch
5 times, most recently
from
September 1, 2023 00:01
fbf7c58
to
f6b5e2a
Compare
kuhe
reviewed
Sep 1, 2023
kuhe
reviewed
Sep 1, 2023
kuhe
reviewed
Sep 1, 2023
kuhe
reviewed
Sep 1, 2023
kuhe
reviewed
Sep 1, 2023
kuhe
reviewed
Sep 1, 2023
packages/protocol-http/src/extensions/httpExtensionConfiguration.ts
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Sep 1, 2023
kuhe
reviewed
Sep 1, 2023
syall
suggested changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I also agree with @kuhe's comments.
syall
reviewed
Sep 1, 2023
syall
reviewed
Sep 1, 2023
AndrewFossAWS
force-pushed
the
http-ext
branch
from
September 4, 2023 17:14
f6b5e2a
to
d8940f5
Compare
kuhe
approved these changes
Sep 5, 2023
syall
suggested changes
Sep 5, 2023
packages/protocol-http/src/extensions/httpExtensionConfiguration.ts
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
http-ext
branch
from
September 5, 2023 22:23
d8940f5
to
08c4f07
Compare
syall
approved these changes
Sep 5, 2023
kstich
added a commit
to kstich/smithy-typescript
that referenced
this pull request
Sep 28, 2023
This commit adds the `LazyJsonString` class that supports holding a String with JSON contents, deserializing to JSON, and being built from JSON like content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds http client component to the runtime extensions.
Using S3 as an example:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.